Add nav generated with vite to Buyer Experience
Step 1: What is changing in this MR?
- Related – Issue: #2750 (closed), Navigation MR: Add Vite, Blog MR: gitlab-blog!20 (closed)
- Bundle sizes look to be down by 90%~
How to review this MR
- Check Navigation/Footer and its breakpoints/dropdowns, Minimized Nav/Footer, Search, Language Selector, etc
- across browsers
- analytics tracking
Lighthouse scores Desktop
- performance metric hovers around 60 in production
Lighthouse scores mobile:
- performance metric hovers around 10 in production
We can only verify the true impacts in production, but so far tests look solid.
Step 2: Ensure that your changes comply with the following, where applicable:
-
I, the Assignee, have run Axe tools on any updated pages, and fixed the relevant accessibility issues. -
These changes meet a specific OKR or item in our Quarterly Plan. -
These changes work on both Safari, Chrome, and Firefox. -
These changes have been reviewed for Visual Quality Assurance and Functional Quality Assurance on Mobile, Desktop, and Tablet. -
These changes work with our Google Analytics and SEO tools. -
These changes have been documented as expected.
Step 3: Add the appropriate labels for triage
This MR will have dex-approval::2-standard automatically applied, but please update it as follows. If deciding between two levels, go with the higher of the two: https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/sites/handbook/source/handbook/marketing/digital-experience/marketing-site-approval-process/index.html.md
Step 4: Tag the appropriate person for review
Depending on which label is used, you may tag the following people as a Reviewer on this MR: https://about.gitlab.com/handbook/marketing/digital-experience/marketing-site-approval-process/#step-3-tag-the-appropriate-people-for-review
Edited by Javier Garcia