Resolve "Contact Sales Form Error Message"

Javier Garciarequested to merge
839-confidential-issue into main

1. Change Summary

[Describe what is changing, why, and the impact]

  • Issue regarding stepped forms: current validate call from Marketo's API is checking all the form input fields, even the ones that aren't present in the UI and on the next step, leading to noise from tracking
    • This will lead to an error on the next step's first input field, as shown below
  • Solutions
    • Add a disabled button state for the first step of the form until all input fields are filled out correctly
    • Add custom validation for the first step of the stepped form, which validates on the UI compared to using vs with Marketo's API.
      • Add hacky custom error handling for the first step. I'm happy to expand on this, but this was necessary because we are not using their validate function; we need to tell the user why the form won't continue with mktoError's content ourselves. I'm happy to explore better alternatives if we can come up with them.
      • This has been thoroughly tested with email fields. I would like to add a comment

2. QA Checklist

[This merge request should follow all best practices utilizing our team code standards and our project's development documentation]

  • Code Cleanup: Any messages, linter warnings, and/or deprecation warnings are cleaned up in the console
  • Tech Debt: I have created, or documented, any fast follow-up work that needs to be done after this MR is merged
  • Common Component Regression Check: I have verified all impacted pages of my common component updates have been checked for regressions and UX is aware of any wider-scoped visual changes
  • Efficient Code Review: I have tested and reviewed my own changes thoroughly before assigning a reviewer
  • Accessibility: Axe tools run and issues addressed
  • Cross-browser compatibility: Works on Safari, Chrome, and Firefox
  • Analytics and SEO: Compatible with Google Analytics and SEO tools
  • Localization checked for regressions
  • Follow the same workflow as the video below, call out any UI funny business
  • Test going back a step, the UI should remain bug-free

Review App

Production Review app
https://about.gitlab.com/sales/ https://839-confidential-issue.about.gitlab-review.app/sales/
https://about.gitlab.com/software-innovation-report/ https://839-confidential-issue.about.gitlab-review.app/software-innovation-report/
Before After
Screen Recording 2025-10-09 at 5.02.34 PM.mov Screen Recording 2025-10-09 at 11.55.39 AM.mov

3. Deployment Steps

[List key deployment steps or configurations]

Closes #839

Edited by Javier Garcia

Merge request reports