Skip to content

Requesting Reviews from other team members.

John Skarbek requested to merge jts/review-gitlab-shell-k8s into master

Good Morning!

I'd like to invite you all to conduct a review this this readiness document for the migration of the GitLab Shell service which is soon to migration from the git fleet of servers, over into a Deployment called gitlab-shell inside of Kubernetes. Please follow the guidelines outlined here when performing this review: https://about.gitlab.com/handbook/engineering/infrastructure/production/readiness/#reviewing-a-proposal

If you feel uncomfortable or are too busy to perform a review, please nominate a substitute.

Please review the following document and leave your questions inline.

If you have no remarks about the content of the text, consider the following questions:

  • Are there failure scenarios that are not discussed?
  • Is there enough documentation in our runbooks such that we can recover from a failure of any mentioned scenario?
  • Are there appropriate Pages in place such that we get alerted when this service begins to fail?
  • Is the documentation in our runbooks sufficient that if the bus factor is high, another member of Infrastructure can successfully troubleshoot and rectify any failure scenario?
  • Are there any improvements one may suggest to either the configuration, visibility of, or tooling for this service?

Closes: delivery#1251 (closed)

Merge request reports