2023-04-24: Deploys failing in staging canary due to 16.0 deprecations
Customer Impact
This is an internal-only issue which affected deployments of 16.0.x omnibus packages.
Current Status
Deployments started failing because Gitaly and Praefect had deprecated configuration structures in Gitlab omnibus. The deployer was checking migration path from previous version (15.x) to new versions (16.x) and failing because of deprecation checks.
A temporary fix has been rolled out to stop checking the deprecations for Gitaly and Praefect, while updating omnibus packages and this has unblocked deployments
Permanent fix is to update Gitaly and Praefect configurations to newer structures.
ToDo:
-
Hotpatch omnibus package to stop deprecation checks for omnibus package updates -
Test/update gitaly and praefect configurations in pre
👉 #9094 (closed) -
Update gitaly and praefect configurations in gstg
👉 #9114 (closed) -
Update gitaly and praefect configurations in gprd
👉 #9541 (closed) -
Fix issue on gstg
replica nodes👉 #9091 (comment 1371775637) -
Revert the hotpatch in omnibus to start checking gitaly/praefect configuration deprecations 👉 gitlab-org/omnibus-gitlab!6852 (merged) -
See if we can remove the hot patches we added - Example of patch we applied #9580 (closed)
More information will be added as we investigate the issue. For customers believed to be affected by this incident, please subscribe to this issue or monitor our status page for further updates.
Incident Review: #13126 (closed)
Corrective Actions:
- Ability to rollback package on GitLab-ctl recon... (gitlab-org/omnibus-gitlab#7797)
- Configuration Deprecation process Refinement fo... (gitlab-org/gitlab#408557)
📚 References and helpful links
Recent Events (available internally only):
- Feature Flag Log - Chatops to toggle Feature Flags Documentation
- Infrastructure Configurations
- GCP Events (e.g. host failure)
Deployment Guidance
- Deployments Log | Gitlab.com Latest Updates
- Reach out to Release Managers for S1/S2 incidents to discuss Rollbacks, Hot Patching or speeding up deployments. | Rollback Runbook | Hot Patch Runbook
Use the following links to create related issues to this incident if additional work needs to be completed after it is resolved:
- Corrective action ❙ Infradev
- Incident Review ❙ Infra investigation followup
- Confidential Support contact ❙ QA investigation
Note: In some cases we need to redact information from public view. We only do this in a limited number of documented cases. This might include the summary, timeline or any other bits of information, laid out in out handbook page. Any of this confidential data will be in a linked issue, only visible internally. By default, all information we can share, will be public, in accordance to our transparency value.