Skip to content

fix: ensure we dont accidentally deploy to staging & production

Gonzalo Servat requested to merge improve-should-deploy-conditions into main

What

  • Ensure we don't deploy of TRIGGER_DRY_RUN is set to any value.
  • For the dry-run job, check if TRIGGER_DRY_RUN is true instead of "true".

Why

After merging !500 (merged), I've noticed that a staging deployment was being triggered and it was due to TRIGGER_DRY_RUN being defined as a boolean while we're comparing it to a string. We really don't want to accidentally deploy to staging or production so this MR makes it so if TRIGGER_DRY_RUN is set to any value, then we're not deploying.

Edited by Gonzalo Servat

Merge request reports