Skip to content

Revert "Merge branch 'jk/bypass-pdm-gstg-cny' into 'master'"

Jenny Kim requested to merge revert-d27a85ae into master

What does this MR do?

Revert "Merge branch 'jk/bypass-pdm-gstg-cny' into 'master'"

This reverts merge request !3216 (merged)

It is being reverted due to BYPASS_SCHEMA_VERSION being null not working as expected.

We realized that the current embedding database schema version is much older than the codebase one, but the schema version check was not marking that as an error. It should have detected that difference, and should have errored out.

We have decided to revert this change for now, and make a new change in the CNG codebase to filter out embedding database schema. (internal slack)

related: gitlab-com/gl-infra/delivery#19688 (closed)

Author Check-list

Please read the Contributing document and once you do, complete the following:

  • Check if all of the following apply:
    • Assign to the correct reviewer per the contributing document
    • Apply the correct metadata per the contributing document
    • Link to related MRs for applying the changes on other environments
    • Link to related Chef changes
    • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

  • Check if all of the following apply:
    • Reviewed the diff jobs to confirm changes are as expected
    • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

  • Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)
Edited by Jenny Kim

Merge request reports

Loading