Allow change-lock job to fail

What does this MR do?

Allow the change-lock job to fail.

Now that we've seen the change-lock job pass when there are no PCLs we should allow the job to fail when there are PCLs.

Example pipeline where the change-lock job passed: https://ops.gitlab.net/gitlab-com/gl-infra/k8s-workloads/gitlab-com/-/pipelines/2149597.

gitlab-com/gl-infra/delivery#19466 (closed)

Author Check-list

Please read the Contributing document and once you do, complete the following:

• Check if all of the following apply:
  • Assign to the correct reviewer per the contributing document
  • Apply the correct metadata per the contributing document
  • Link to related MRs for applying the changes on other environments
  • Link to related Chef changes
  • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

• Check if all of the following apply:
  • Reviewed the diff jobs to confirm changes are as expected
  • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

• Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)