Skip to content

Ensure that changes to secrets create an appropriate pipeline

John Skarbek requested to merge jts/ensure-jobs-created-for-secrets into master

What does this MR do?

  • This adds changes to the gitlab-secrets release result in a pipeline that contains jobs that create the secrets as desired
  • Without this, we were too restrictive with our changes rules and due to such, we were unable to proper deploy/change existing secret objects

Addresses: gitlab-com/gl-infra/delivery#2410 (closed)

Author Check-list

Please read the Contributing document and once you do, complete the following:

  • Check if all of the following apply:
    • Assign to the correct reviewer per the contributing document
    • Apply the correct metadata per the contributing document
    • Link to related MRs for applying the changes on other environments
    • Link to related Chef changes
    • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

  • Check if all of the following apply:
    • Reviewed the diff jobs to confirm changes are as expected
    • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

  • Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)
Edited by John Skarbek

Merge request reports