Skip to content

Let's take other releases into account for CI

John Skarbek requested to merge jts/fix-mods-for-other-releases into master

What does this MR do?

  • When we made CI jobs more environment specific, we forgot about other releases
  • This adds the appropriate matching such that we match any release given an environment and stage
  • Evidence:
irb(main):002:0> File.fnmatch('/gitlab/**/foo.yaml', '/gitlab/gitlab/foo.yaml')
=> true
irb(main):003:0> File.fnmatch('/gitlab/**/foo.yaml', '/gitlab/gitlab-version/foo.yaml')
=> true

Author Check-list

Please read the Contributing document and once you do, complete the following:

  • Check if all of the following apply:
    • Assign to the correct reviewer per the contributing document
    • Apply the correct metadata per the contributing document
    • Link to related MRs for applying the changes on other environments
    • Link to related Chef changes
    • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

  • Check if all of the following apply:
    • Reviewed the diff jobs to confirm changes are as expected
    • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

  • Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)
Edited by John Skarbek

Merge request reports