Skip to content

Add check-label-taxonomy CI check for proper labels on resources

Jenny Kim requested to merge jennykim/template-labels-check into master

What does this MR do?

For issue gitlab-com/gl-infra/delivery#2248 (closed) to add CR check for proper labels (overall epic gitlab-com/gl-infra&687 (closed)).

Right now, we have no way of making sure that resources have metadata labels matching our Prometheus metadata label taxonomy of type (service identifier), tier, stage (cny, main, blue, green, etc) and shard (marquee, hdd, urgent-cpu-bound etc).

This check script will create manifest templates and check each resource to see if any of them are missing these labels.

Author Check-list

Please read the Contributing document and once you do, complete the following:

  • Check if all of the following apply:
    • Assign to the correct reviewer per the contributing document
    • Apply the correct metadata per the contributing document
    • Link to related MRs for applying the changes on other environments
    • Link to related Chef changes
    • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

  • Check if all of the following apply:
    • Reviewed the diff jobs to confirm changes are as expected
    • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

  • Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)
Edited by Jenny Kim

Merge request reports