Skip to content

Adds extraDir volume mount for jmalloc reporting - Staging

What does this MR do?

  • I generically decided to add this as a diagnostic reporting location
  • As the temporary location is controlled via env variable, we need to override the default location of /tmp to the location where our emptyDir is being created
  • We target all webservice deployments for which run the Rails code base
  • These reports will be captured to a temporary location on disk
    • Thus we use an emptyDir with a size cap to control the growth of said directory
  • We set a very low size for these reports to prevent our nodes from running out of disk space
    • With a limit of 1GB, a long running Pod that is accumulating reports will be Evicted when the size limit is exceeded
  • This only creates the volume mount, this feature is not yet enabled and requires an environment variable to be set before reports are generated.
    • This will occur at a later time when the feature is merged
  • Note that we are NOT using the medium type Memory such that we leverage disk space vs a tmpfs mount and that the limit imposed is not counting towards the RAM allocated to the Pod
  • This is meant to be temporary as currently retrieving these files will be a manual operation. A future iteration will move these reports for easier grasping, hopefully with the end result that this emptyDir configuration will be removed: gitlab-org/gitlab!91283 (comment 1013698089)
  • Risk and Performance of this feature overall was evaluated here: gitlab-org/gitlab!91283 (merged)

Handles our webservices for work happening inside: gitlab-org/gitlab!91283 (merged)

Delivery Tracking issue: gitlab-com/gl-infra/delivery#2486 (closed)

Author Check-list

Please read the Contributing document and once you do, complete the following:

  • Check if all of the following apply:
    • Assign to the correct reviewer per the contributing document
    • Apply the correct metadata per the contributing document
    • Link to related MRs for applying the changes on other environments
    • Link to related Chef changes
    • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

  • Check if all of the following apply:
    • Reviewed the diff jobs to confirm changes are as expected
    • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

  • Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)
Edited by John Skarbek

Merge request reports

Loading