Prevent accidents when testing the deploy pipeline
A pipeline was manually triggered: https://ops.gitlab.net/gitlab-com/gl-infra/deployer/pipelines/85351 that specified a targeted version for which to deploy. This bypassed our check here: https://ops.gitlab.net/gitlab-com/gl-infra/deployer/blob/master/.gitlab-ci.yml#L16 and led to a non dry run style of deploying the targeted version specified. This was not intentional and is the opposite of what our documentation states: https://gitlab.com/gitlab-org/release/docs/blob/master/general/deploy/gitlab-com-deployer.md, specifically:
Note that all pipelines initiated on branches will automatically set the
--dry-run
flag which can be useful for testing.
We've since provided the ability to ADD an attribute to force checkmode to be set for a dry run here: https://ops.gitlab.net/gitlab-com/gl-infra/deployer/blob/master/.gitlab-ci.yml#L22; however, if that ENV variable is unset, we run the risk of accidentally deploying something unintentionally.
Utilize this issue to determine how we can mitigate mistakes in the future.