Make gitlab-registry Helm chart Istio ready
Problem statement
Currently, we have two issues with GitLab registry Helm chart.
- Migration job which is not finishing properly because of the sidecar container injected. See similar Github issue
- Helm chart does have global annotations support, but doesn't support annotations on migrations job. We can disable sidecar injection using
sidecar.istio.io/inject: "false"
annotation on a particular job, but we don't want to disable it for the whole registry component. We need to add ability to add job annotation to the helm chart. See this code
What can we do with it?
- Modify the job and run
curl -fsI -X POST http://localhost:15020/quitquitquit
when migration is finished. But here we need some condition which detecting istio sidecar. We don't want to execute it if there is no sidecar. - Add migrations.annotation value to specify annotations for the migration job
Edited by Vladimir Glafirov