Issues with MR master merged and unassigned to the bot are not considered valid
When the scheduled security validation prevents the automatic merging of a security MR (see #1231 (closed)), the bot unassigns itself (as expected). If the merge request targeting master is merged, but unassigned to the bot, our tooling considers it as not ready to be processed
https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/973
Example -- MWPS was set by the bot - https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/973#note_420007080
- Validation kicked in preventing the automatic merging - https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/973#note_420026964
- Bot unassigned himself (as expected) - https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/973#note_420026968
- Discussion was solved by Release Manager and the MR was merged
- When executing
/chatops run release merge --dry-run --security --master
the associated issue was consideredPending
because the MR targetingmaster
was not assigned to the bot (even if it was merged)
- Assigning the MR back to the bot, made our tooling consider the issue as
Ready
again
We can probably fix this by fixing #1231 (closed) or by modifying Security::ImplementationIssue#merge_requests_assigned_to_the_bot?
to only considered opened merge requests. I'd be inclined to wait until #1231 (closed) is fixed, since there shouldn't be any scenario in which processed merge requests are not assigned to the bot