Skip to content

First simple version for mobile

Guillaume Remy requested to merge remyguillaume/gg-viewer:simple-mobile into main

Description

This is a first simple version of a mobile interface.
It contains a map, a themes/layers selector, a search and a 2D/3D switch.
It is accessible with /mobile.html.

Job done

Mobile interface:

  • Add new interface mobile.html at the root of the project, with a corresponding main.mobile.ts
  • Add style for mobile
  • Create component search-mobile that extends search to redefine templating and styling
  • Remove fontawesome from themes component
  • Create new component themes-mobile that is in charge of selecting basemaps, themes and layers
  • Build the 2 interfaces with vite.
  • Add file config.mobile.json for mobile specific configuration. (only mapbs, sitn and cartoriviera have one at the mobile) If mobile, both config.json and config.mobile.json will be laoded. The content of config.mobile.json will overwrite the content of config.json. This allows to redefine only the necessary options for mobile.

APK:

  • Enable Fullscreen mode for the app
  • Use the same build-apk script locally and in CI
  • Build APK for MapBS and SITN in the CI
  • Use the new mobile interface to create APK.

Definition of Done

For the Developer:

  • Code compiles and conforms to defined coding standards (eslint, tsc, prettier).
  • If necessary (at the developer's discretion), unit tests have been added for critical parts.
  • All unittests run without error.
  • Sonar-Scan returns no new issues or security hotspots.
  • Documentation has been updated where necessary (see documentation repository).
  • Merge-Request contains a few explanations of what was done.
  • A Reviewer has been assigned to the Merge-Request.

For the Reviewer:

  • New code was reviewed.
  • If comments could be added on unclear code, the developer has been informed.
  • If unitests could be added in certain places, the developer has been informed.
  • Merge-Request was merged on main branch.
  • All pipelines work.
  • The changes were tested on demo environment.
  • Application performance has not been degraded by the modifications.
Edited by Stéphane Malta e Sousa

Merge request reports