Skip to content

Be able to query WMTS layers linked to WMS layers

Benjamin requested to merge ger-benjamin/gg-viewer:292-query-wmts-layers into main

Description

For #292 (closed) A WMTS layer with a metadata queryLayers or wmsLayers should be queryable. This MR add this possibility on WMTS layers.

Job done

  1. Fill the new queryLayers property in the model.
  2. Add a wmtsManager.selectFeatures method to collect WMTS-with-WMS layer to query
  3. Handle the feature id. Before, an id with a point in the name (like a layer named ch.alpina.limits) would have been broken.
  4. Grid and Window component don't crash anymore with query returning features without any property. (filter out thee features)
  5. Fix FocusFeature for feature without geometry. (ignore them)

It's hard to know if that works in all cases. I'm especially not sure if it should be possible to do WFS GetFeature query on WMTS. Currently the new code will only makes GetFeatureInfo requests.

Definition of Done

For the Developer:

  • Code compiles and conforms to defined coding standards (eslint, tsc, prettier).
  • If necessary (at the developer's discretion), unit tests have been added for critical parts.
  • All unittests run without error.
  • Sonar-Scan returns no new issues or security hotspots.
  • Documentation has been updated where necessary (see documentation repository).
  • Merge-Request contains a few explanations of what was done.
  • A Reviewer has been assigned to the Merge-Request.

For the Reviewer:

  • New code was reviewed.
  • If comments could be added on unclear code, the developer has been informed.
  • If unitests could be added in certain places, the developer has been informed.
  • Merge-Request was merged on main branch.
  • All pipelines work.
  • The changes were tested on demo environment.
  • Application performance has not been degraded by the modifications.
Edited by Benjamin

Merge request reports