Skip to content

Migrate to uHtml v4

Guillaume Remy requested to merge remyguillaume/gg-viewer:uHtml-v4 into main

Description

A new major version of uHtml has been release. GeoGirafe has to use this new version.

Job done

  • Reference the new version of uHtml and make the necessary changes
  • Manage caching for unsafe content
  • uHtml comes now with a right module definition, so remove the dummy declare module for this library
  • Moved the vitest configuration (nothing to do with this change, but it caused some problems while running the UT)
  • Exclude devDependency from job executing npm outdated to check only the important dependencies.
  • Because of breakings changes, the version is now 0.6

Definition of Done

For the Developer:

  • Code compiles and conforms to defined coding standards (eslint, tsc, prettier).
  • If necessary (at the developer's discretion), unit tests have been added for critical parts.
  • All unittests run without error.
  • Sonar-Scan returns no new issues or security hotspots.
  • Documentation has been updated where necessary (see documentation repository).
  • Merge-Request contains a few explanations of what was done.
  • A Reviewer has been assigned to the Merge-Request.

For the Reviewer:

  • New code was reviewed.
  • If comments could be added on unclear code, the developer has been informed.
  • If unitests could be added in certain places, the developer has been informed.
  • Merge-Request was merged on main branch.
  • All pipelines work.
  • The changes were tested on demo environment.
  • Application performance has not been degraded by the modifications.
Edited by Guillaume Remy

Merge request reports