Skip to content

samba-support: update packaging

xiota requested to merge xiota/garuda-pkgbuilds:pr_samba-support into main

Note: I don't use samba. Someone who does should test this.

Changes that affect system security:

  • Uses systemd-sysusers to create sambashare group.
  • Does not add users to the group on install.
  • Does not delete the group on uninstall.
  • Prints messages on install, update, uninstall.
  • Sets group owner (recursive) of /var/lib/samba/usershares to sambashare on install.
  • Sets group owner (recursive) of /var/lib/samba/usershares to root on uninstall, if not empty.

General packaging changes:

  • Change system-config-samba optdep to mx-samba-config (-git).
  • Move depends inside package function to reduce resource usage during build.
  • Change /var/lib/samba/usershare to usershares for compatibility with mx-samba-config.

Install and upgrade message:

==> NOTE: The group 'sambashare' has been created,
==>       and is the group owner of the folder:
==>           /var/lib/samba/usershares
==>
==> NOTE: To add users to 'sambashare':
==>           usermod -a -G sambashare [username]

Uninstall message:

==> NOTE: The group 'sambashare' was created on install.
==>       Do not forget to check file ownership
==>       before removing the group with the command:
==>           groupdel sambashare
==>
==> NOTE: The following folder was created on install.
==>           /var/lib/samba/usershares
==>       Do not forget to check content ownership
==>       before removing the folder.

Fixes #5

Edited by xiota

Merge request reports