Skip to content

[x86] Peephole optimizer - minor lineinfo change (fixes #40792)

J. Gareth "Kit" Moreton requested to merge CuriousKit/optimisations:inc-lineinfo-fix into main

Summary

This merge request changes the MovAdd2Lea and MovSub2Lea optimisations very slightly so the lineinfo points to what was originally the arithmetic instruction rather than the MOV. This permits easier debugging (in some cases, you couldn't set a breakpoint on the Pascal code that was compiled into the ADD or SUB instruction). This fixes the issue raised in #40792 (closed).

System

  • Processor architecture: i386, x86_64

What is the current bug behavior?

In situations where the MovAdd2Lea and MovSub2Lea optimisations are applied, some useful debugging information was lost.

What is the behavior after applying this patch?

The lineinfo now points to the arithmetic instruction.

Relevant logs and/or screenshots

See #40792 (closed).

Merge request reports