Skip to content

[Bug Fix] Added missing "override" directive for XML node dump routine on TDerefNode

J. Gareth "Kit" Moreton requested to merge CuriousKit/optimisations:nmem-xml-missing-override into main

Summary

This merge request inserts a missing override directive for the XMLPrintNodeInfo method definition for TDerefNode. This causes the compiler to not build when -dDEBUG_NODE_XML is specified due to a warning that is treated as an error by the make script.

System

  • Processor architecture: Cross-platform

What is the current bug behavior?

The compiler fails to build when -dDEBUG_NODE_XML is specified, giving the following warning (x86_64-win64 demonstrated):

C:/Users/garet/Documents/programming/fpc-opts/compiler/ppc1.exe -Ur -Xs -O2 -n -Fux86_64 -Fusystems -FuC:/Users/garet/Documents/programming/fpc-opts/rtl/units/x86_64-win64 -Fix86_64 -FEx86_64/bin/x86_64-win64 -FUx86_64/units/x86_64-win64 -dRELEASE -a -O2 -dDEBUG_NODE_XML    -dx86_64 -dGDB -Fux86 -Fix86 -Sew -oC:/Users/garet/Documents/programming/fpc-opts/compiler/ppc2.exe pp.pas
nmem.pas(122,21) Warning: (treated as error) An inherited method is hidden by "XMLPrintNodeInfo(var Text);"
nmem.pas(186,1) Fatal: There were 1 errors compiling module, stopping
Fatal: Compilation aborted

What is the behavior after applying this patch?

The compiler builds successfully when -dDEBUG_NODE_XML is specified.

Merge request reports