Skip to content

[x86 / Refactor] Debug source line fixes

J. Gareth "Kit" Moreton requested to merge CuriousKit/optimisations:imul2leashl-debug-refactor into main

Summary

This merge request fixes some faulty fileinfo fields in x86 optimisations (only visible in a debugger or when building with the -al option) which would associate lines of assembly language to the end of the procedure (the default location) instead of where the original unoptimised instructions pointed.

Some very minor restructuring was done in the area of the fixes for reasons of code maintainability, but should not change the output of a compiled source file (other than the associated source lines).

System

  • Processor architecture: i386, x86_64

What is the current bug behavior?

When analysing the assembly language under -al, a lot of lines point to the current procedure's final end; terminator instead of the correct line of source code.

What is the behavior after applying this patch?

A lot of these known issues of incorrect source lines have been corrected.

Relevant logs and/or screenshots

Virtually every optimised source file sees a change to the associated source line and are too numerous to list. However, the actual assembly language does not change, hence is a pure refactor.

Merge request reports