Skip to content

[AArch64] Bug fix where an assembly entry was assumed to be an instruction and not actually checked

J. Gareth "Kit" Moreton requested to merge CuriousKit/optimisations:aarch64-bad-typecast-fix into main

Summary

This merge request fixes a bug in the Peephole Optimizer for AArch64, specifically the OptPass1MOV routine, where a list entry was assumed to be an instruction and not actually checked, leading to an invalid typecast error under -CriotR rules or unpredictable behaviour otherwise.

System

  • Operating system: Linux (Raspberry Pi OS), very likely others
  • Processor architecture: AArch64
  • Device: Raspberry Pi

What is the current bug behavior?

When building the compiler under -O2 -CriotR rules, an invalid typecast exception was raised in the ppc1 stage.

What is the behavior after applying this patch?

Compiler now builds successfully.

Merge request reports