Skip to content

Refactor max framing

cec m requested to merge reg_rework_2 into master

Description

This merge request refactors max framing to avoid exporting sequences with large black borders after the registration step (saves space and processing time). This has been done for both Apply Existing Registration and Apply Astrometric Registration. As a consequence, sequences registered with max framing are sequences with variable image sizes and a residual pixel-wise shift still contained in the .seq file. When at stacking step, a maximize framing option is now avalaible (been implemented for sum, min, max and mean/rej stacking) that recomputes the output size. This option can also be used for same-size sequences, created for instance by KOMBAT, Image pattern alignment or 1-star, to maximize the output as well.
The upscale at stacking option has been removed for methods that only write shifts. It is now handled at the stacking step. It is also removed from the .seq file (version has been bumped to v5).

Changes Made

  • In applyreg and astrometric, treat max framing as a special case and export sequence with residual shifts
  • In all stacking methods, add a maximize framing option and an upscale at stacking option (they can be combined)
  • Removed upscale at stacking from .seq files specification

Related Issues

Provide links to the related issues or feature requests.

Additional Notes

Still TODO:

  • disable max framing at registration for fitseq sequences
  • disable max framing at registration for SER sequences
  • revisit available export options/boxes for all registration methods and only show/enable the ones that can effectively be used
  • revisit available export options/boxes for all stacking methods and only show/enable the ones that can effectively be used
  • update/check seqapplyreg command
  • update/check seqapplyastrometry command
  • update/check stack commands

Merge Request Checklists

Edited by cec m

Merge request reports