Skip to content

Draft: Move action note generation after all info is generated for chat-attack

I was attempting to add an effect note for an individual attack based on the ammo it was using. So I was patching ChatAttack's method that generates the effect notes to add in some extra notes. I went to check the ammo and saw that it hadn't been set at the point where the effect notes are being generated. This moves the generation for both the individual attack's effect note and the whole action's foot notes to the end of the block where the chat-attacks are generated. This makes it so that all of the data that has been added to the chat-attack is available for use when the notes are generated.

This is marked as a draft because I haven't had a chance to test it at this point. But it's open for feedback/suggestions/etc. I'll remove the draft tag after I have a chance to test it. I also didn't include a changelog because it doesn't change any normal functionality. Though an argument could be made that it can include an API changelog since it allows slightly more functionality for anyone patching particular methods.

Merge request reports