Skip to content

Refactor Mailbox to Vue

Christian Walgenbach requested to merge rest-api-mailbox into master

Closes #1203 (closed) #755 (closed) #234 (closed) #1126 (closed), #848 (closed)

Part of #939 #1181

What does this MR do?

ToDo

  • unit tests
  • translation
  • more than one recipient
  • toggle icon to collapse mailbox container
  • attachments - slack
    • Sent emails with attachments don't have attachments anymore when arriving in maildev
    • File types other than images throw an error
    • being able to handle old attachments (different file path on the server) -> is implemented, needs to be tested
    • delete old and new files in MailboxGateway::deleteMessage (move the actual deletion to MailboxTransactions)
  • Frontend validation: sending should only be possible if subject, recipient etc. are filled
  • add links to the attachments in the frontend
  • The backend should return emails even if the attached files do not exist anymore -> is implemented, needs to be tested
  • Check if the images in /img/icon-mail can be deleted
  • Delete or clean up Mailbox.css
  • Add the file size to the attachment links in the frontend. If the filesize is zero, the file does not exist anymore on the server. In that case the link should not be clickable.
  • Confirm before finally deleting an email
  • Being able to move emails from trash back to other folders (requires a new Rest endpoint)

follow-up issue

#1668

How confident are you it won't break things if deployed?

Links to related issues

How to test

Screenshots (if applicable)

desktop

old new
image image
image image
image image
image image

mobile

old new
image image
image image
image image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Das Modul "E-Mail-Postfächer" wurde vollständig mit aktuellen Technologien überarbeitet.

Edited by Christian Walgenbach

Merge request reports