Skip to content
Snippets Groups Projects

Upgrade sentry-symfony to version 4.2

Merged Fridtjof requested to merge sentry-upgrade into master
All threads resolved!

What does this MR do?

Just updates the sentry-symfony integration (from 3.5 to 4.2). This will enable new features (like performance tracing).

Note that tracing is not enabled yet, for that we will have to set the sample rate. I think it would be a good idea to set different sample rates depending on beta vs prod, but that's for later.

How confident are you it won't break things if deployed?

I followed the guide at https://github.com/getsentry/sentry-symfony/blob/master/UPGRADE-4.0.md. Still, it might break in prod - dev obviously does not send messages to sentry.io. Of course, I checked that the website still runs.

Let's try it in beta!

Links to related issues

How to test

  1. check out locally
  2. update packages
  3. check the website still works

Checklist

  • no test needed, just a dependency bump
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Fridtjof

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fridtjof added forDev + 1 deleted label

    added forDev + 1 deleted label

  • Fridtjof mentioned in commit 15831f8f

    mentioned in commit 15831f8f

  • Fridtjof marked the checklist item added an entry to CHANGELOG.md as completed

    marked the checklist item added an entry to CHANGELOG.md as completed

  • Fridtjof added 1 commit
  • Alex approved this merge request

    approved this merge request

  • Fridtjof mentioned in commit 93c0ae1b

    mentioned in commit 93c0ae1b

  • Fridtjof added 7 commits

    added 7 commits

    Compare with previous version

  • Fridtjof enabled an automatic merge when the pipeline for 93c0ae1b succeeds

    enabled an automatic merge when the pipeline for 93c0ae1b succeeds

  • merged

    • Resolved by Alex

      Symfony now fails in docker: Attempted to call an undefined method named "getCurrentHub" of class "Sentry\SentryBundle\SentryBundle".

      Symfony\Component\ErrorHandler\Error\UndefinedMethodError {#419
        #message: "Attempted to call an undefined method named "getCurrentHub" of class "Sentry\SentryBundle\SentryBundle"."
        #code: 0
        #file: "./var/cache/dev/ContainerRdTJYIk/Foodsharing_KernelDevDebugContainer.php"
        #line: 1338
        trace: {
          ./var/cache/dev/ContainerRdTJYIk/Foodsharing_KernelDevDebugContainer.php:1338 {
            ContainerRdTJYIk\Foodsharing_KernelDevDebugContainer->getHubInterfaceService()
            › {
            ›     $this->privates['Sentry\\State\\HubInterface'] = $instance = \Sentry\SentryBundle\SentryBundle::getCurrentHub();
      
          }
          ./var/cache/dev/ContainerRdTJYIk/getErrorListenerService.php:22 { …}
          ./var/cache/dev/ContainerRdTJYIk/Foodsharing_KernelDevDebugContainer.php:669 { …}
          ./var/cache/dev/ContainerRdTJYIk/Foodsharing_KernelDevDebugContainer.php:1106 { …}
          ./vendor/symfony/event-dispatcher/EventDispatcher.php:245 { …}
          ./vendor/symfony/event-dispatcher/EventDispatcher.php:76 { …}
          ./vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:290 { …}
          ./vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:145 { …}
          ./vendor/symfony/console/Application.php:995 { …}
          ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
          ./vendor/symfony/console/Application.php:290 { …}
          ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
          ./vendor/symfony/console/Application.php:166 { …}
          ./bin/console:33 { …}
        }
      }
  • Alex resolved all threads

    resolved all threads

  • Fridtjof mentioned in merge request !2047 (merged)

    mentioned in merge request !2047 (merged)

  • Fridtjof mentioned in issue #1064 (closed)

    mentioned in issue #1064 (closed)

Please register or sign in to reply
Loading