Skip to content

Sentry: make tracing sample rate configurable per environment (disabled by default)

Fridtjof requested to merge sentry-tracing-samplerate into master

Followup to !2042 (merged)

What does this MR do?

Adds a new define "SENTRY_TRACING_SAMPLE_RATE" that can be set in an environment config file to enable Sentry's performance tracing feature.

I would recommend starting with a lower value, so we can look at how much overhead this introduces. We can increase it over time, then. Second, I'd recommend setting a higher value for beta, due to a lower number of users (therefore we need to sample more to get good data).

How confident are you it won't break things if deployed?

shouldn't break anything, I've added a default value for the new define, akin to how other defines work.

Links to related issues

#1064 (closed)

How to test

Checklist

  • no test needed, just a configuration change
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

(-) (irrelevant to users)

Edited by Fridtjof

Merge request reports