The Store Model Purge, a Tragedy in 3 Acts. Act 1.
What does this MR do?
Starts removing StoreModel by removing a few of the less tangled methods, and introduces a basic Store DTO for creating new stores.
How confident are you it won't break things if deployed?
hm. I broke less with these changes than those in the followup MRs listed below, so there is that.
Links to related issues
- #1029 (closed)
- !1800 (merged)
- !1809 (merged) <- you are here
- !1810 (closed)
- !1811 (merged)
- !1814 (merged)
How to test
As store manager:
- create new stores
- manipulate store team membership
As store team member:
- leave stores
As any foodsaver in a region:
- check if the two store lists still show correct data
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
Edited by Fridtjof