Skip to content

The Store Model Purge, a Tragedy in 3 Acts. Act 3.

Chris Oelmueller requested to merge store-model-xhr into master

What does this MR do?

closes #1012 (closed)

from !1810 (closed):

  • reimplement moving store team members to or from standby team in REST
  • reimplement xhr_warteRequest in REST, remove that StoreModel part
  • refactor StoreModel::teamRequest with StoreTransactions and in REST
  • UI skeleton: new simple dialog to add users to store team, and buttons to promote/demote store managers

How confident are you it won't break things if deployed?

uhhh.

Links to related issues

How to test

(from !1810 (closed))

  • apply for store team and send request to standby team (waiting list / jumpers)
  • move existing team members to and from standby team (just like before, no UI change)
  • get familiar with the store-team management mode. if enabled, you should see an input field to add new team members, and buttons to promote / demote store managers. they will not work yet!

(from !1811 (merged))

  • log in as store manager
  • perform any store-team related management actions:
    • adding new members
    • removing members
    • moving members to/from standby list
    • promoting/demoting store managers
    • handling join requests

Screenshots

(from !1810 (closed))

image
image

(from !1811 (merged))

image
image
image

Checklist

  • added some API tests (more would be even better)
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Edited by Alex

Merge request reports