You need to sign in or sign up before continuing.
Resolve "If some bells are unread, the button is disabled. Same for chat conversation."
requested to merge 1016-if-some-bells-are-unread-the-button-is-disabled-same-for-chat-conversation into master
Closes #1016 (closed)
What does this MR do?
- Activate the button "Alle als gelesen markieren", if bells or messages are unread.
- Closes the popup for messages and bells
How confident are you it won't break things if deployed?
I dont know...
Links to related issues
The problem comes into beta with MR: !1736 (merged)
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Write a message to Bot
- Write a message on the store board
- Add you to a slot of the store
- Login with another foodsaver
- Write again a message to Bot
- Login with Bot
- You should have now 2 unread messages and 2 bells. Click on the messages button.
- Click on the new Button "Alle als gelesen markieren" --> All messages should marked as read.
- Message popup should be closed.
- Click on the bells button.
- Click on the new Button "Alle als gelesen markieren" --> All bells should marked as read.
- Bell popup should be closed.
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes --> Not needed -
Once your MR has been merged, you are responsible to create a testing issue in [Beta Testing Repo] (https://gitlab.com/foodsharing-dev/foodsharing-beta-testing): - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)
Edited by ToLei