Skip to content
Snippets Groups Projects

Finalize the Great Translation Purge

Merged Finalize the Great Translation Purge
refactor/translation-purge into master
All threads resolved!
Merged Chris Oelmueller requested to merge refactor/translation-purge into master
All threads resolved!

What does this MR do?

  • finish translation-refactoring: Settings* and the very basics of Report*/Quiz*
  • replace hardcoded role logic with new getRoleName helper
  • remove all PHP translations! and associated infrastructure
    • this includes moving all implicit form-field translations to YAML
  • update i18n devdocs

How confident are you it won't break things if deployed?

Much to my surprise, the build for this is green. It would be pretty good to test the changes through and through, since it's related to core functionality (displaying text)

How to test

Basically: do things and check if the text you are seeing is what you expected. A lot. :poop:

Checklist

  • no added functionality that wasn't already covered by tests
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Chris Oelmueller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • -
  • -
  • -
    - @fs_k
    Maintainer

    Looked through it , if some of my comments are too unrelated to this merge they can be moved / closed.

    Approved. Would be nice to have another person as well to look through it.

  • Chris Oelmueller added 52 commits

    added 52 commits

    Compare with previous version

    Toggle commit list
  • Chris Oelmueller marked the checklist item added an entry to CHANGELOG.md as completed

    marked the checklist item added an entry to CHANGELOG.md as completed

  • Chris Oelmueller resolved all threads

    resolved all threads

  • Chris Oelmueller merged

    merged

  • Chris Oelmueller
    Chris Oelmueller @ChrisOelmueller
    Author Contributor

    Suggestion - since it has been waiting for review for a while - !1666 (merged) get's merged on the 20th if there are no objections against it?

    Since there was no resistance and no requests to wait where someone wanted to review but lacked time right now, here we go -- beta testing as review :smile:

  • Chris Oelmueller
    Chris Oelmueller @ChrisOelmueller
    Author Contributor

    beta => https://gitlab.com/foodsharing-dev/foodsharing-beta-testing/-/issues/24

  • Chris Oelmueller removed 1 deleted label

    removed 1 deleted label

    • Please register or sign in to reply