Slightly refactor pickup-edit frontend

What does this MR do?

Refactor pickup-edit frontend ;-)

• introduce Milestone constants
• split out inline CSS, remove unused or duplicated rules
• remove most of the unused even/odd computations
• translate some strings, condense and move other translations
• build helper functions to replace (very!) repeated select options
• fix duplicate select options in newfetchtime rows
• refactor v_bezirkChooser to v_regionPicker
• FoodSharePoint translation and refactoring (this is a larger commit)
• annotate PageHelper

How confident are you it won't break things if deployed?

pretty sure

Links to related issues

• &22 (closed)
• &7 (closed)

How to test

• as store manager: view and edit the recurring pickup dates
• as store manager: add a new manual pickup date

Checklist

• no test: no functional changes
• no unrelated changes
• asked someone for a code review
• set a "for:" label to indicate who will be affected by this change
• use "state:" labels to track this MR's state until it was beta tested
• added an entry to CHANGELOG.md
• forDev => no release notes
• Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
  • Consider writing a detailed description in German.
  • Describe in a few sentences, what should be tested from a user perspective.
  • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
  • Be aware, that also non technical people should understand.

changed milestone to %Release 'Cranberry': October 2020

added forDev typeRefactoring + 1 deleted label

changed the description

approved this merge request

added 15 commits

• 78daa5c1 - 1 commit from branch master
• 50c7a3b0 - &6 (closed) [noop] Slightly touch up XhrMethods
• 61988fca - FoodsaverXhr touch-up
• 99e461ae - Dashboard: Condense permission check
• 37c674e4 - Remove unused CSS
• 1ee2a38a - TimeHelper: Clarify getDow and string building
• a16c0c0a - Dashboard: combine two similar functions into one
• 11af380e - Reshuffle some CSS, remove unused rule
• 99950606 - &7 (closed) Start with StoreUserControl translation
• 3204e6d0 - Refactor XhrMethods:xhr_getPinPost, introduce Milestone constants
• 5f3ce054 - &7 (closed) &22 (closed) Refactor pickup edit screen, shuffle some CSS + translations around
• fbe53ed7 - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• a5ebaff6 - &7 (closed) Move Store form translations to de.php
• d6565eff - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• e2e58690 - Annotate PageHelper

Compare with previous version

changed the description

added 8 commits

• f46ba64b - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• e012748d - &7 (closed) Move Store form translations to de.php
• 2942ec4d - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• 5ebf0237 - Annotate PageHelper
• 3536f418 - &7 (closed) Translate SettingsControl
• 26994699 - &7 (closed) SettingsView translation
• 70abfe90 - &7 (closed) Translate SettingsXhr
• 6b1d0461 - &7 (closed) translationHelper->getRoleName

Compare with previous version

added 73 commits

• 6b1d0461...e44a5182 - 59 commits from branch master
• 11174d12 - &6 (closed) [noop] Slightly touch up XhrMethods
• c14032af - FoodsaverXhr touch-up
• a2659c46 - Dashboard: Condense permission check
• 5eed3b06 - Remove unused CSS
• 049066f8 - TimeHelper: Clarify getDow and string building
• 14caa44c - Dashboard: combine two similar functions into one
• 0e020ae3 - Reshuffle some CSS, remove unused rule
• 8c8bc42c - &7 (closed) Start with StoreUserControl translation
• 06a93e17 - Refactor XhrMethods:xhr_getPinPost, introduce Milestone constants
• 0262fb28 - &7 (closed) &22 (closed) Refactor pickup edit screen, shuffle some CSS + translations around
• 0cda23a8 - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• 2cc0b5d4 - &7 (closed) Move Store form translations to de.php
• 492c86f8 - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• 8382386a - Annotate PageHelper

Compare with previous version

mentioned in merge request !1666 (merged)

marked the checklist item added an entry to CHANGELOG.md as completed

added 15 commits

• 8382386a...c3c44d7b - 9 commits from branch master
• 42dec05d - Refactor XhrMethods:xhr_getPinPost, introduce Milestone constants
• e08bb576 - &7 (closed) &22 (closed) Refactor pickup edit screen, shuffle some CSS + translations around
• 56c098f9 - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• 18262d78 - &7 (closed) Move Store form translations to de.php
• c303b57d - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• 9950f20c - Annotate PageHelper

Compare with previous version

changed the description

added 9 commits

• 9950f20c...b3aaa38d - 2 commits from branch master
• a434de0e - Refactor XhrMethods:xhr_getPinPost, introduce Milestone constants
• 52e2876a - &7 (closed) &22 (closed) Refactor pickup edit screen, shuffle some CSS + translations around
• 7d644952 - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• 294c65e7 - &7 (closed) Move Store form translations to de.php
• 118a3a49 - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• 42b326ed - Annotate PageHelper
• a2770cf2 - Account for possible null results in WallPostGateway

Compare with previous version

added 32 commits

• a2770cf2...d6a0f446 - 25 commits from branch master
• b64a50ef - Refactor XhrMethods:xhr_getPinPost, introduce Milestone constants
• e9ee818e - &7 (closed) &22 (closed) Refactor pickup edit screen, shuffle some CSS + translations around
• ee253ecc - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• 0cf369d0 - &7 (closed) Move Store form translations to de.php
• 5c5caa6e - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• 580048ed - Annotate PageHelper
• a4a3df65 - Account for possible null results in WallPostGateway

Compare with previous version

added 15 commits

• a4a3df65...a295861a - 8 commits from branch master
• 3e03a43b - Refactor XhrMethods:xhr_getPinPost, introduce Milestone constants
• ef217ce2 - &7 (closed) &22 (closed) Refactor pickup edit screen, shuffle some CSS + translations around
• cafb8510 - &7 (closed) &22 (closed) Refactor v_bezirkChooser to v_regionPicker
• 9ce6bb05 - &7 (closed) Move Store form translations to de.php
• 573f48ed - &6 (closed) &7 (closed) FoodSharePoint translation and refactoring
• 44d3f0a2 - Annotate PageHelper
• 16620e5b - Account for possible null results in WallPostGateway

Compare with previous version

merged

assigned to @ChrisOelmueller