Skip to content

Possible fix for Sentry's #vue-pickuplist issue

Christian Wansart requested to merge bugfix/fix-sentry-vue-pickuplist-issue into master

Related to #633 (closed) nr 24)

What does this MR do?

Delays the vueApply('#vue-pickuplist') calls until the document is fully loaded. This should fix the issue.

How confident are you it won't break things if deployed?

Tilmann made the statement that delaying it should work. Since #vue-pickuplist gets added via PHP it should be available as soon as the document is ready. So I think wrapping the code inside a $(document).ready() should be sufficient.

Links to related issues

related pages when running locally

Checklist

  • added a test, or explain why one is not needed/possible... <-- cannot be tested locally
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller

Merge request reports