(beta) pickup slot checklist
This is an attempt to keep an overview about possibly open tasks:
General things:
-
2) (low prio) solved in 992c3835 ? if pickup date is in next year, the time isn't visible -> wrap text since it only happens around new year or shorten weekday to two letters? Or add the time to a new line by default (possible impact on tests?)
-
- The closing x is placed weirdly. Taken care in another issue: #731 (closed)
- The closing x is placed weirdly. Taken care in another issue: #731 (closed)
-
4) (low prio) solved in 992c3835 ? Higher contrast to plus symbol. f1e7c9
-
5) it should be allowed to confirm past pickups as a bieb. (currently possible - good)
-
6) it should not be allowed for biebs/bots to delete people from slots in the past. (currently possible - bad)
-
7) ⚠ ️ (very high prio) it should not be allowed for pickers to sign out of past pickups (currently possible - bad)
-
8) As a result of 7) Red error 400: Happens to me if I delete the whole past pickup date as a BIEB. Past pickup dates should only be allowed to be deleted if nobody signed up for them.
-
9) ⚠ ️ (high prio) (merged 9 with 17) If there are more people in a date than slots available this date gets invisible. This can get people in trouble during migration period and probably should be "fixed" at least for migration time. Solving it the sql-way is really hard since it happens for both automatic and one-time slots. Those or deleted pickup dates with signed in people is visible in production but not beta: https://yunity.slack.com/archives/C1T1ZM9A4/p1560626405344700
Add another user to be able to test it. Orga user with another browser for example. Needs to be in the team!
-
- (NOT fixed but "closed" due to very low prio) Changing the pickup time of automatic slots lets people disappear from slots but still being signed up for this pickup. Handeld over at issue #124 (closed)
-
- (NOT fixed but "closed" due to very low prio) Changing the automatic slot duration from 4 to 2 weeks with users being signed up for slots in week 3 oder 4 they disappear from the list but are still signed up for these slots. Might not happen often. Not critical. I think users will understand this.
-
13) (low prio) If a user is sending a empty cancelling message, there is a green success message afterwards. After this message disappears, a red waring appears. Maybe add a flash alert as a warning or disable the button until a symbol-count is re-enabling the button and allowing to send?
https://codepen.io/CSWApps/pen/RQbvvp
-
14) ⚠ ️ fixed? (high prio) It should be possible to join a manual pickup date which is in february for example. If you join this date you get an error message. It looks like it didn't succeed, but on dashboard you can see you've joined this date successfully (="invisible picker"). Reloading the slot menu doesn't show your avatar. Only a BOT can remove you via profile pickup list.
-
15) fixed? Might be related to 14) and possibly 8): Deleting this manual slot with an invisible picker (see 14)) via X-symbol or context menu shows this error. Slot can be deleted after your slot got deleted by a BOT:
-
16) !963 (merged) (proposal)
The "Abholtermine" menu frame should only be visible for stores which are "In Kooperation" (=active cooperation:betrieb_status_id
both3
or5
)
-
- idential to 9)
-
18) (own decision - this adds power to BOTs and ORGA compared to previous implementation) You should not be allowed to confirm pickups of yourself unless you are a BIEB of this store. It is currently available for BOTs and ORGA
-
19) (own decision - this adds power to BOTs and ORGA compared to previous implementation) Similar to 18) You should not be allowed to confirm pickups of OTHERS unless you are a BIEB of this store. It is currently available for BOTs and ORGA
-
20) (own decision - this adds power to BOTs and ORGA compared to previous implementation) You should not be allowed to kick/delete pickups of others unless you are a BIEB of this store. It is currently available for BOTs and ORGA. Would vote for removing it despite they are able to do it via the profile slot menu of a user anyway. It makes it harder for them but adds another step where BOT/ORGA can think about why they are managing a store that someone else is responsible for.
-
21) Red warning: https://yunity.slack.com/archives/C74JC2V26/p1561055533072200
-
22) 967988be (proposal)
This extends the time range to join a slot until/including $to date var/parameter. Otherwise longer dates passed by the $to parameter or our new default value are not able to join. Previous explanation: !947 (comment 182039034)
Related: !1061 (merged)
-
23) ⚠ ️ (high prio) If no prefetchtime is selected OR if the pickup date is too far in the future (april): Every signed in "picker" starting tomorrow is invisible. Instead an empty slot is shown. This is uncomfortable for stores with manual/one-time pickups only. Festival pickups, sos-event-team pickups, regular pickups but at different times and so on.
See also #633 (comment 221428666)
-
24) Discussion: https://yunity.slack.com/archives/C1T1ZM9A4/p1569579882146800
Investigate this error (vueUse-Error: no elements were found with selector '#vue-pickuplist'
): https://sentry.io/organizations/foodsharing-ev/issues/1236533325/?project=1400918&query=%23vue-pickuplis&statsPeriod=14d
https://sentry.io/share/issue/ab37e66321694900b2ebe3be3dd3acf8/
-
25) (high prio) proposal: !1061 (merged)
You should not be able to see a slot (automatic/regular) without being able to get it assigned.Actual behaviour on beta for a BIEB is that if you click on that slot it gets deleted.
Currently on beta it is not possible for fs and above to click on this slot. It's greyed out.
Problem only occurs with automatic/regular slots. You have to create a automatic slot at current weekday which is in the future to test it.
See also discussion on Slack: https://yunity.slack.com/archives/C1T1ZM9A4/p1569067250044300
Edited by Johannes