Skip to content

Respect report regions also for empty list

Matthias Larisch requested to merge fix-report-for-no-region into master

What does this MR do?

When looking at reports for a region without subregions, all reports against ambassadors have been addded. This is due to fluentpdo making

$regions = [];
$query = $query->where('fs.bezirk_id', $regions);

into a noop (https://github.com/envms/fluentpdo/issues/293) - I still don't know if that is actually right, but it feels wrong... Anyway, manually check this edge case and do not show all reports in that situation.

How confident are you it won't break things if deployed?

Tested in production (...), works.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible... tested manually, too lazy for elaborated test case
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s)) no changelog entry because new bug

Merge request reports