Skip to content

Check for non-null string to show pickup amount in store

Sven Oos requested to merge 546-show-pickup-amount-in-store-if-set-over-50-kg into master

Closes #546 (closed)

What does this MR do?

This MR fixes a bug that prevents the pickup amount to be shown in store if it is set over 50kg. The fix compares the set amount from the store against null. Before the string value was compared to be greater than 0, which only worked for strings with a leading digit.

How confident are you it won't break things if deployed?

Very confident

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports