Skip to content

Bugfix in the AddBasketAction

David requested to merge dthulke/foodsharing:basket-rest-fixes into master

What does this MR do?

It fixes two bugs in the AddBasketAction (afaik currently only used in the Android App):

  • getValidatedDescriptionOrThrowException did not return the description and as a result it was not set in the new basket
  • The BasketService expects the items in CONTACT_TYPES to be ints but the paramFetcher returns them as strings

How confident are you it won't break things if deployed?

Very confident

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Peter Tönnies

Merge request reports