Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
F
foodsharing
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 203
    • Issues 203
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 34
    • Merge Requests 34
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • foodsharing-dev
  • foodsharing
  • Merge Requests
  • !748

Merged
Opened Feb 20, 2019 by Michael Aydinbas@pmaydContributor5 of 5 tasks completed5/5 tasks

Fix issue with user role on dashboard

  • Overview 10
  • Commits 3
  • Pipelines 5
  • Changes 3

Closes #52 (closed)

What does this MR do?

The user role on the foodsaver dashboard was wrongly associated with the home district. This resulted in texts like 'Botschafter für xyz". Although user is an ambassador for some region x, this has not to be his/her home district.

Issue was solved by deleting this sentence completely as was argued that the user should be aware of their roles anyway. Instead, I added more information about the user's activity. Now we have three informations: Number of fetch counts, total fetch weight and the home district.

_52_dashboard_fix

If there is no fetch weight or fetch count, only the home district is shown.

How confident are you it won't break things if deployed?

Very, only text/shown information was changed, no internal logic

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited Feb 20, 2019 by Peter Tönnies
Assignee
Assign to
Reviewer
Request review from
Hackweek February 2019
Milestone
Hackweek February 2019 (Past due)
Assign milestone
Time tracking
Reference: foodsharing-dev/foodsharing!748
Source branch: 52-pmayd-fix-user-role-on-dashboard