Skip to content

Prevent non closeable bells from being closed

Jano requested to merge prevent_non_closeable_bells_from_being_closed into master

What does this MR do?

Currently, bell notifications that are marked as non-closeable can be removed anyway. That's a huge problem, as it enables people to close their unconfirmed fetch bells – which would mean that they will never receive updates about new fetches, unless the bells are restored somehow.

This MR fixes this.

This can also be seen as a hotfix for !559 (comment 121030764)

How confident are you it won't break things if deployed?

I'm completely sure it will not break things.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports