Skip to content

Standardise chat js

Nick Sellen requested to merge standardise-chat-js into master

What does this MR do?

I noticed the js in chat/ looked totally different to that in client/ so I made them look the same by adding a similar eslint configuration :)

Also noticed that it was using node 6 in the docker images still (even though https://gitlab.com/foodsharing-dev/images/blob/master/chat/Dockerfile was 10.12 too, probably forgot to update a version number). But anyhow 10.12 comes with yarn anyway so it's not needed.

How confident are you it won't break things if deployed?

Should be ok!

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports