Skip to content

Resolve "Bugfix that checks indices in the BasketGateway"

Alex requested to merge 354-basketgateway-bugfix into master

Closes #354 (closed)

What does this MR do?

Checks array indices while requesting details of a basket in BasketRequest.getBasket (and the same in APIGateway). This prevents a warning and makes sure false is returned if the basket id does not exist.

How confident are you it won't break things if deployed?

All methods that depend on this can handle the boolean return value and I added a unit test. So, very sure

Links to related issues

#354 (closed)

Checklist

  • added a test, or explain why one is not needed/possible: added unit test
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Peter Tönnies

Merge request reports