Skip to content

Update production yarn deps

Nick Sellen requested to merge update-production-yarn-deps into production

What does this MR do?

Production deployed to replace homepage failed because upath specifies it needs node <=9 (and we have v10.6.0). A yarn upgrade means we use a patch version higher which relaxes the restraint.

See https://gitlab.com/foodsharing-dev/foodsharing/-/jobs/81398264

  The command "cd ~/production-deploy/releases/13 && (cd client && yarn && ya  
  rn build)" failed.                                                           
                                                                               
  Exit Code: 1 (General error)                                                 
                                                                               
  Host Name: production                                                        
                                                                               
  ================                                                             
  warning You are using Node "10.6.0" which is not supported and may encounte  
  r bugs or unexpected behavior. Yarn supports the following semver range: "^  
  4.8.0 || ^5.7.0 || ^6.2.2 || ^8.0.0"                                         
  warning package.json: No license field                                       
  warning foodsharing-frontend@1.0.0: No license field                         
  error upath@1.0.4: The engine "node" is incompatible with this module. Expe  
  cted version ">=4 <=9".                                                      
  error Found incompatible module  

How confident are you it won't break things if deployed?

Well, it upgrades all the npm deps (within range), but if the test pass, should be ok :)

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Nick Sellen

Merge request reports