Skip to content

Refactor Manualdb, part 1

Tilmann Becker requested to merge refactor-manualdb into master

What does this MR do?

Move methods out of ManualDb.php to get rid of it eventually.

Notable changes:

  • move more session access into S.php, start to deprecate session access inside Func
  • stop using plain $gateway class variable, instead always give them a telling name (e.g. $storeGateway)
  • database methods fetch, fetchAll and fetchAllValues should now consistently return arrays. Before, PHP would sometimes return false if no object was found.

Part 2 will follow soon :)

How confident are you it won't break things if deployed?

Added some tests and clicked around, but it will most probably break something...

Links to related issues

#9 (closed)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports