Refactor Manualdb, part 1
What does this MR do?
Move methods out of ManualDb.php
to get rid of it eventually.
Notable changes:
- move more session access into
S.php
, start to deprecate session access insideFunc
- stop using plain
$gateway
class variable, instead always give them a telling name (e.g.$storeGateway
) - database methods
fetch
,fetchAll
andfetchAllValues
should now consistently return arrays. Before, PHP would sometimes returnfalse
if no object was found.
Part 2 will follow soon :)
How confident are you it won't break things if deployed?
Added some tests and clicked around, but it will most probably break something...
Links to related issues
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller