Skip to content

Fix pickup slot display

Nick Sellen requested to merge fix-pickup-slots into master

Closes #215 (closed)

What does this MR do?

I had removed a line [1] that looked like it was just an assignment to an unused variable. What I had not noticed is that the getAbholdates method has side effects (it adds stuff to $g_data which is read later).

[1] https://gitlab.com/foodsharing-dev/foodsharing/blob/7109e2c37494442e8a53e5bb3e36bc8b79ac546b/src/Modules/StoreUser/StoreUserControl.php#L705

How confident are you it won't break things if deployed?

Very, it's a simple revert of one line.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible... sorry, too tired and lazy
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports