follow-up after profile refactoring to vue
What does this MR do?
- Resolve "
TypeError: Foodsharing\Modules\Group\GroupFunctionGateway::existRegionFunctionGroup(): Argument #1 ($target_id) must be of type int, null given, called in /var/www/beta/releases/1094/src/Modules/Profile/ProfileController.php on line 269" - Use markdown for "about me internal
- show not all badges for / as foodsharer
- show profile tab only if other tabs are visible
How confident are you it won't break things if deployed?
Links to related issues
How to test
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
set the "API change" label if changes in the API are not backward compatible -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Anton Ballmaier