Skip to content

Remove obsolete version field from docker compose files

Fridtjof requested to merge docker-compose-remove-version into master

What does this MR do?

The version field in docker compose files has been obsolete for some time: https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element-obsolete

Recent docker compose versions have started printing explicit warnings about this:

$ scripts/docker-compose up -d
WARN[0000] /home/fridtjof/repos/foodsharing/docker/docker-compose.yml: `version` is obsolete 
WARN[0000] /home/fridtjof/repos/foodsharing/docker/docker-compose.dev.yml: `version` is obsolete

How confident are you it won't break things if deployed?

very

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Fridtjof

Merge request reports