Skip to content

Fix an bug in date-formatter

Alex requested to merge 1948-fix-js-date into master

Closes #1948 (closed)

What does this MR do?

Fixes the rendering of dates/times in the frontend. The date formatter is used in many places. I can't say which one triggers the error. But it seems to happen when the date to be rendered is close (< 1 second) to now.

How confident are you it won't break things if deployed?

Quite sure. I don't know how to test it in the frontend, but you can run the js function for two dates that are equal and it works.

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Closes #1948 (closed)

Merge request reports