Move WebSocket-Server communication to one class
Related to #1769
What does this MR do?
Currently the session class setups the oauth-information for the websocket server. The replacement of the Session-class by Symfony session it could be moved out and be only part of the login/logout process.
This MR moves the redis access to an separate class which works similar as in the Session class, but outside of it.
How confident are you it won't break things if deployed?
Hope not
Links to related issues
How to test
- Open RedisInsight and check redis content no session related content exists
- Open foodsharing page
- PHPREDIS_SESSION could exists but no php/user//sessions
- Login with user
- Redis should contain a session ID in php/user//sessions
- Logout user
- Redis should not contain the session ID in php/user//sessions
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
set the "API change" label if changes in the API are not backward compatible -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Closes #1769
Edited by Alex