Skip to content

Remove unused or duplicate user information from Session Storage

KoeMai requested to merge 1959_remove_unused_session_fields into master

Closes #1959 (closed)

What does this MR do?

The session load during start much information. Some of this information are not used, or historical artefacts.

  • User bezirk_id Is part of client to and there is a method to get the information
  • Foodsaver type Only read but never updated
  • verified Stored twice in Session Move usage to Method isVerifed()
  • mailbox_id never read
  • last_activity Stored twice in session
  • token = Activation token Never used

This MR remove some fields, removes redundancy in session and/or replaces the access way to some information to reduce multiply storages.

How confident are you it won't break things if deployed?

I think not, test works well.

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by KoeMai

Merge request reports