Skip to content

Allow multiple images in baskets

Anton Ballmaier requested to merge 1797-image-cropping-ux-issues into master

Closes #1797

What does this MR do?

Allows to upload multiple images for food baskets. As a first step towards #1714 this also includes quite a bit of cleanup in the backend basket code (mainly using DTOs).

How confident are you it won't break things if deployed?

Images uploaded from beta will be displayed as broken images in prod.

Links to related issues

&38 (closed)

Screenshots (if applicable)

Click to expand

Editing / Creating baskets with mutiple images:

Screenshot_from_2024-05-08_15-10-00

This is how multiple images are displayed on the basket page:

Screenshot_from_2024-05-08_15-12-34

The first image is used as a preview:

Screenshot_from_2024-05-08_15-12-43

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Anton Ballmaier

Merge request reports